error-prone-support

error-prone-support copied to clipboard

Introduce BugPattern for removing duplicate `Mockito.verifyNoInteractions()` calls

3

### Problem When verifying that mocks didn't have interactions in tests sometimes many calls to `Mockito.verifyNoInteractions()` are used `verifyNoInteractions(mock1);` `verifyNoInteractions(mock2);` which unnecessarily pollutes the code, because this method actually accepts...

Kamil-Gabaydullin

Avoid inserting blank lines in ErrorProneTestHelperSourceFormat auto-fix

6

Thanks for the great package of checks! I tried to apply ErrorProneTestHelperSourceFormat and its autofixes to our tests in NullAway, and saw that blank lines get inserted as `""`. E.g.:...

msridhar

Have `ReverseOrder` rule flag `Collections.reverseOrder(String::compareTo)`

3

Encountered this problem when testing downstream. Without this rule this: ``` Collections.reverseOrder(String::compareTo) ``` Would be replaced with: ``` Collections.reverseOrder(Comparator.naturalOrder()) ``` Which is incompatible so it would lead to non compilable...

rickie

### Problem Reactor's `PublisherProbe` defines a neat API to test reactive code. However, it is only helpful when it is _actually_ used. Considering the following code snippet, the `PublisherProbe` is...

werli

Rewrite `buildDescription(tree).addFix(fix).build()` to `describeMatch(tree, fix)`

1

### Problem In commit https://github.com/google/error-prone/commit/570f0bf23af457aa323b0efcd8e1ba182eddbb13 the `DescribeMatch` `BugChecker` got removed from Error Prone with the explanation that it got ported to Refaster. As we cannot see these kind of changes,...

rickie

Improve naming of assorted Refaster templates and associated tests

3

This PR contains code of #25 . We want to prepare the Refaster templates such that we can easily add the annotations `@Template{,Collection}` in the appropriate places. In the afternoon...

rickie