Stefan S

See https://github.com/pilight/pilight/pull/431

Thank you for the reminder! At the moment I'm a Bit lost in the Project, do you have a hint for me where to go on?

I did a quick testusing the your raspyrfm branch: `./pilight-unittest test_lua_hardware_raspyrfm_send` And I get: ``` There was 1 failure: 1) test_lua_hardware_raspyrfm_send: /home/pi/dev/pilight/tests/lua_hardware_raspyrfm.c:474: expected but was ``` Do you have the...

While doing some tests concerning the topic https://forum.pilight.org/showthread.php?tid=3522 I got an issue; the hwtype was set too late so that pilight can handle multiple hardware. I forced push and will...

> > > > I forced push and will bring it also to the staging branch. > > What actually changed? Also here, the setting of hwtype

> > > What i also don't get is how you set a rawlen of 32 pulses on line 202, while you expect a rawlen of 50 pulses on line...

> > > I'm currently porting the hardware module to lua, but i noticed that the unittest doesn't yet cover everything. > > What i countered till this far: >...

> Here various parameters are set, but the test doesn't check if they are all set with the correct values: > https://github.com/pilight/pilight/pull/434/files#diff-37f44c5e034922929cf9d82ace01b336R323 The rfmcfg are hardcoded values for the RFM69...

> How can i be sure about that when porint the whole thing to lua and not having the device itself. Good point. I added checking of rfmcfg.

> Does the unittest work or fail and why? It will fail. You are writing wrong values in wrong registers. In the unittest all register writes are catched, and if...