photonvision
photonvision copied to clipboard
Add match data to snapshot names
Hey!
I've added the feature that issue #457 suggests - which is adding the match data to the snapshot's filename.
Now, when taking a snapshot, The file's suffix will be the match type(Practice, Quals, Elimination etc.) followed by the match's number, fetched from the FMSInfo
table. please note that if that table doesn't exist, PhotonVision will create it.
I've added a validation method, what do you think?
Well, it seemed like a better practice, because we won't want to overwrite any data published to those entries. The goal when calling this functions is to create the entries if they didn't exist before, but not changing any information in them.
Yeah I suppose it doesn't hurt to create the entries, but I just don't think it strictly helps is all and side effects outside the photonvision table seems unideal. @Bankst thoughts?
@OfirSiboni any interest in pushing this through before our kickoff release?
Hey, haven't touched the project in a while. Is it still relevant? You are welcome to push it if so.
Should be ready for review