photonvision icon indicating copy to clipboard operation
photonvision copied to clipboard

Add match data to snapshot names

Open OfirSiboni opened this issue 2 years ago • 6 comments

Hey! I've added the feature that issue #457 suggests - which is adding the match data to the snapshot's filename. Now, when taking a snapshot, The file's suffix will be the match type(Practice, Quals, Elimination etc.) followed by the match's number, fetched from the FMSInfo table. please note that if that table doesn't exist, PhotonVision will create it.

OfirSiboni avatar May 08 '22 16:05 OfirSiboni

I've added a validation method, what do you think?

OfirSiboni avatar May 08 '22 18:05 OfirSiboni

Well, it seemed like a better practice, because we won't want to overwrite any data published to those entries. The goal when calling this functions is to create the entries if they didn't exist before, but not changing any information in them.

OfirSiboni avatar May 10 '22 15:05 OfirSiboni

Yeah I suppose it doesn't hurt to create the entries, but I just don't think it strictly helps is all and side effects outside the photonvision table seems unideal. @Bankst thoughts?

mcm001 avatar May 13 '22 01:05 mcm001

@OfirSiboni any interest in pushing this through before our kickoff release?

mcm001 avatar Dec 22 '22 14:12 mcm001

Hey, haven't touched the project in a while. Is it still relevant? You are welcome to push it if so.

OfirSiboni avatar Dec 24 '22 11:12 OfirSiboni

Should be ready for review

mcm001 avatar Jan 04 '23 13:01 mcm001