photonvision icon indicating copy to clipboard operation
photonvision copied to clipboard

Remove Erode / Dilate from Colored Shape or Make them Useful

Open jasondaming opened this issue 3 years ago • 1 comments

These options seem to do nothing currently.

jasondaming avatar Feb 10 '22 20:02 jasondaming

I saw this too. It appears that the code is currently commented out. I made some modifications and got it working. A couple of suggestions. 1) Make these into "open" and "close" operations - These may be more useful. 2) If not added to the user interface, update the kernel size based on screen resolution ( <=320 -- 2, <=640 -- 4, otherwise 5 ), 3) Perhaps implement Open, Close, Open and allow user to select which ones to use so they can select the order. (Maybe even implement a count 1-3 -- not certain if repeated actions help or not.) These appear to be fairly efficient in terms of CPU usage and seem to speed up the actions that follow. I'd be happy to share the code changes if desired.

jsimpso81 avatar Feb 13 '22 04:02 jsimpso81

This issue still seems to be there. Is there any plan to fix it?

StephenDay1 avatar Feb 27 '23 15:02 StephenDay1

Not by me personally imminently, but PRs are welcome!

mcm001 avatar Mar 02 '23 13:03 mcm001