photonvision icon indicating copy to clipboard operation
photonvision copied to clipboard

Fix typo in NeuralNetworkModelManager

Open Space646 opened this issue 4 weeks ago • 4 comments

Description

Changed 'Hair drier' --> 'Hair dryer'

Meta

Merge checklist:

  • [*] Pull Request title is short, imperative summary of proposed changes
  • [*] The description documents the what and why
  • [*] If this PR changes behavior or adds a feature, user documentation is updated
  • [*] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • [*] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • [*] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • [*] If this PR addresses a bug, a regression test for it is added

Space646 avatar Dec 18 '25 07:12 Space646

This is actually how it's spelled in the original COCO dataset (https://arxiv.org/pdf/1405.0312, page 14). I don't really want to diverge from that, so I think we should keep the original spelling. Perhaps a note that this is the original spelling is warranted?

Gold856 avatar Dec 18 '25 07:12 Gold856

[*] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes [*] The description documents the what and why [*] If this PR changes behavior or adds a feature, user documentation is updated [*] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly [*] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 [*] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated [*] If this PR addresses a bug, a regression test for it is added

just some advice for the future, if you leave this blank github will make checkboxes. alternately, you can fill them by doing - [x] like so

  • [x] stuff here

samfreund avatar Dec 18 '25 08:12 samfreund

Oops, sorry. Weird that it's spelled that way, but I guess as long as it works it's fine.

I changed it back to how it was previously and added a comment as @Gold856 suggested.

Space646 avatar Dec 18 '25 08:12 Space646

Error: Linting failed. See https://docs.photonvision.org/en/latest/docs/contributing/linting.html

samfreund avatar Dec 18 '25 13:12 samfreund