photonvision icon indicating copy to clipboard operation
photonvision copied to clipboard

Github action workflow triggers

Open thatcomputerguy0101 opened this issue 1 month ago • 6 comments

Only running workflows on pushes to main and PRs may be insufficient for making testing as easy as possible within reason. One solution would be to add the workflow_dispatch trigger to enable specific workflows to be run on-demand. Another solution would be running on all pushes, which is at risk of notification spam (and is also wasteful on compute, which while free, is probably best to not abuse).

thatcomputerguy0101 avatar Dec 09 '25 01:12 thatcomputerguy0101

Another advantage of adding workflow_dispatch is that an option menu can be presented before running, eg. for selecting which images to build in case only certain results are of concern.

thatcomputerguy0101 avatar Dec 09 '25 01:12 thatcomputerguy0101

I support doing this. One more benefit is that it makes it easier to test code in a fork without having to create a PR.

crschardt avatar Dec 09 '25 02:12 crschardt

PR and I'll approve 👍

samfreund avatar Dec 09 '25 02:12 samfreund

Do you need to do anything to enable the option menu, or will that appear automatically once you add workflow-dispatch?

crschardt avatar Dec 09 '25 02:12 crschardt

I think it appears if inputs are configured under the workflow_dispatch option.

thatcomputerguy0101 avatar Dec 09 '25 02:12 thatcomputerguy0101

Personally, I like having everything run on push, and just disable notifications on Actions (I don't feel a need to be notified immediately) and selectively enable/disable Actions when needed, but if it's nicer to just click the button, I'm not opposed.

Gold856 avatar Dec 09 '25 04:12 Gold856