PhotonVision
Rip out legacy config provider
Description
We don't need this anymore for backwards compat, so we're getting rid of it! Less code, less clutter.
Meta
Merge checklist:
- [ ] Pull Request title is short, imperative summary of proposed changes
- [ ] The description documents the what and why
- [ ] If this PR changes behavior or adds a feature, user documentation is updated
- [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
- [ ] If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
- [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
- [ ] If this PR addresses a bug, a regression test for it is added
I think you'll need to remove some of older network settings tests. May as well just go through and clean up all the old configs in test-resources as well.
I think you'll need to remove some of older network settings tests. May as well just go through and clean up all the old configs in test-resources as well.
Likely, I just kinda ripped and touched the tests a little bit. I'll go through more thoroughly later when I have the chance.
Are we sure we don’t want to change the database schema or anything? I think Matt was interested removing the separate JSON columns in favor of unifying all of them into one.
Are we sure we don’t want to change the database schema or anything? I think Matt was interested removing the separate JSON columns in favor of unifying all of them into one.
Like unifying all the various settings and config files?
Are we sure we don’t want to change the database schema or anything? I think Matt was interested removing the separate JSON columns in favor of unifying all of them into one.
Let’s discuss that in an issue and come up with a plan for a different structure.
I would vote to keep the 1488 diff separate, just to make keeping track of commits once this is squashed more clear
