photonvision icon indicating copy to clipboard operation
photonvision copied to clipboard

Chris pv stream viewer systemcore

Open gerth2 opened this issue 6 months ago • 6 comments

Description

Added an ipk that shows mjpeg streams for all cameras it sees

image

very WIP closes nothing

Meta

Merge checklist:

  • [ ] Pull Request title is short, imperative summary of proposed changes
  • [ ] The description documents the what and why
  • [ ] If this PR changes behavior or adds a feature, user documentation is updated
  • [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • [ ] If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • [ ] If this PR addresses a bug, a regression test for it is added

gerth2 avatar Jun 30 '25 00:06 gerth2

image

gerth2 avatar Jun 30 '25 00:06 gerth2

Consider displaying each camera as a single block, and making the raw and processed streams toggleable (when both are on the block would expand). Name by hostname then camera name, and perhaps show port if user hovers?

samfreund avatar Jul 04 '25 17:07 samfreund

Dark favicon is a better choice, since atp the SystemCore theme is also dark by default, and there doesn't seem to be a light mode.

samfreund avatar Jul 04 '25 18:07 samfreund

Publish the .ipk with the release.

samfreund avatar Jul 04 '25 18:07 samfreund

image It's showing there's no MJPEG stream found for dupe, but the two right after it are, in fact, the feed from the dupe camera

samfreund avatar Jul 04 '25 18:07 samfreund

Consider renaming to Photon Viewer for brevity, as the current title doesn't fit within a tab. Additionally, this would exhibit consistency with what we currently title our client windows in a browser.

samfreund avatar Jul 04 '25 18:07 samfreund