photonvision icon indicating copy to clipboard operation
photonvision copied to clipboard

Tighten static ip regex

Open mcm001 opened this issue 11 months ago • 3 comments

Closes https://github.com/PhotonVision/photonvision/issues/1750 by only allowing .10-.19

mcm001 avatar Jan 27 '25 05:01 mcm001

Does this new pattern block people from setting arbitrary IP addresses when they are connected to a home router rather than the robot? I’m on my phone now, so I can’t easily check. I can investigate tonight if you don’t know the answer.

crschardt avatar Jan 27 '25 15:01 crschardt

Does this new pattern block people from setting arbitrary IP addresses when they are connected to a home router rather than the robot? I’m on my phone now, so I can’t easily check. I can investigate tonight if you don’t know the answer.

We might want to notify the user that the address is outside legal competition range, but still allow them to set it.

samfreund avatar Jan 27 '25 15:01 samfreund

Yes, it totally blocks anything outside of that range. Which if your router is handing out dhcp leases there, you're kinda sol.

mcm001 avatar Jan 27 '25 16:01 mcm001