photonvision icon indicating copy to clipboard operation
photonvision copied to clipboard
verified publisher icon PhotonVision

Don't Pass Empty Resolutions

Open Juniormunk opened this issue 1 year ago • 4 comments

Juniormunk avatar Jan 17 '25 14:01 Juniormunk

What set of conditions made this happen again? How can I test that this fixes things?

Also, merge conflict.

mcm001 avatar Jan 21 '25 04:01 mcm001

Merrrge conflicts

mcm001 avatar Jan 27 '25 00:01 mcm001

Unless we have a burning reason to merge, let's wait till 2026?

mcm001 avatar Feb 13 '25 05:02 mcm001

I don't actually think this does anything. My testing indicated that the entire client falls apart (at least in dev) when there's no video modes because it attempts to access the array at any index, and that returns undefined, which then propagates everywhere and causes UI elements to vanish. The array is just empty, not undefined.

Gold856 avatar Dec 10 '25 00:12 Gold856