photonvision icon indicating copy to clipboard operation
photonvision copied to clipboard

Don't cancel in-progress on main

Open mcm001 opened this issue 1 year ago • 5 comments

mcm001 avatar Jan 12 '25 04:01 mcm001

Actually, is this behavior something we want? I can see an argument for not gumming up Actions when we merge a lot of stuff quickly.

mcm001 avatar Jan 12 '25 05:01 mcm001

Actually, is this behavior something we want? I can see an argument for not gumming up Actions when we merge a lot of stuff quickly.

I guess it depends on if there is any value for those Actions completing for every merge to main. If there is a workflow failure, after merging, would it help to see which merge caused the failure? If we cancel the Actions, then a string of merges might lead to a failed action but it wouldn't be clear which specific merge caused the problem.

crschardt avatar Jan 12 '25 05:01 crschardt

Yeah that's exactly what i was trying to get at. Peter mentioned that allwpilib had seen formatting failures sneak in, but nothing major/breaking. Generally I dont think we have a terribly long queue if we just wait a bit after merging a bunch.

Also need to update other build workflows.

mcm001 avatar Jan 12 '25 05:01 mcm001

Nah, I prefer new commits canceling the workflows of old commits.

Gold856 avatar Aug 09 '25 05:08 Gold856

Why?

mcm001 avatar Aug 09 '25 13:08 mcm001