photonvision icon indicating copy to clipboard operation
photonvision copied to clipboard

Show board outliers in calibration info card

Open mcm001 opened this issue 1 year ago • 2 comments

Pipes back to photon directly mrcal outliers and optimized board pose. Goes with https://github.com/PhotonVision/mrcal-java/pull/4/ and requires https://github.com/PhotonVision/photonvision/pull/2214

image image image

Reprojection error data on main vs this MR, including a fix for "false" (opencv) charuco boards where we weren't ignoring ignored corners:

Main Main Matt's MR
Calibrate3dPipeTest > calibrateTestMatrix(CalibrationDatasets, boolean) > [1] SQUARES_LIFECAM_480, true STANDARD_OUT RMS Reprojection Error: 0.38192536506598534 RMS Reprojection Error: 0.33577593512471376
Calibrate3dPipeTest > calibrateTestMatrix(CalibrationDatasets, boolean) > [2] SQUARES_LIFECAM_480, false STANDARD_OUT RMS Reprojection Error: 1.0580504936756594 RMS Reprojection Error: 1.0580504936756594
Calibrate3dPipeTest > calibrateTestMatrix(CalibrationDatasets, boolean) > [3] SQUARES_LIFECAM_1280, true STANDARD_OUT RMS Reprojection Error: 0.8168208100792993 RMS Reprojection Error: 0.7159327531283418
Calibrate3dPipeTest > calibrateTestMatrix(CalibrationDatasets, boolean) > [4] SQUARES_LIFECAM_1280, false STANDARD_OUT RMS Reprojection Error: 2.0494151762764936 RMS Reprojection Error: 2.0494151762764936
Calibrate3dPipeTest > calibrateTestMatrix(CalibrationDatasets, boolean) > [5] CHARUCO_LIFECAM_480, true STANDARD_OUT RMS Reprojection Error: 0.3072208877612695 RMS Reprojection Error: 0.2975728236616564
Calibrate3dPipeTest > calibrateTestMatrix(CalibrationDatasets, boolean) > [6] CHARUCO_LIFECAM_480, false STANDARD_OUT RMS Reprojection Error: 1009.3690116953635 RMS Reprojection Error: 0.5127304814432004
Calibrate3dPipeTest > calibrateTestMatrix(CalibrationDatasets, boolean) > [7] CHARUCO_LIFECAM_1280, true STANDARD_OUT RMS Reprojection Error: 0.5319664503422203 RMS Reprojection Error: 0.5373510159628804
Calibrate3dPipeTest > calibrateTestMatrix(CalibrationDatasets, boolean) > [8] CHARUCO_LIFECAM_1280, false STANDARD_OUT RMS Reprojection Error: 18256.975012936167 RMS Reprojection Error: 1.0127259170530452
Calibrate3dPipeTest > calibrateTestMatrix(CalibrationDatasets, boolean) > [9] CHARUCO_OLDPATTERN_LIFECAM_480, true STANDARD_OUT RMS Reprojection Error: 0.39632201737448564 RMS Reprojection Error: 0.36835572504426434
Calibrate3dPipeTest > calibrateTestMatrix(CalibrationDatasets, boolean) > [10] CHARUCO_OLDPATTERN_LIFECAM_480, false STANDARD_OUT RMS Reprojection Error: 1282.37016241995 RMS Reprojection Error: 0.822132764305405
Calibrate3dPipeTest > calibrateTestMatrix(CalibrationDatasets, boolean) > [11] CHARUCO_OLDPATTERN_LIFECAM_1280, true STANDARD_OUT RMS Reprojection Error: 0.5545049332256538 RMS Reprojection Error: 0.5568386572683223
Calibrate3dPipeTest > calibrateTestMatrix(CalibrationDatasets, boolean) > [12] CHARUCO_OLDPATTERN_LIFECAM_1280, false STANDARD_OUT RMS Reprojection Error: 1315.1252803237867 RMS Reprojection Error: 1.5874786318023275

mcm001 avatar Mar 06 '24 06:03 mcm001

cleaned up target tab, fixed calibration visualizer resizing, and made both calibration and 3d visualizers conform to theme image

DevonRD avatar Dec 19 '25 07:12 DevonRD

Needs docs. Perhaps a little info icon that users can hover over to explain the general premise then more in depth on the docs page.

The first person viewer is wack, I would do third-person only.

View calibration information popup updates too slowly Screencast from 12-19-2025 01:24:58 AM.webm

samfreund avatar Dec 19 '25 07:12 samfreund