scripts icon indicating copy to clipboard operation
scripts copied to clipboard

use APPLICATION_ID when creating a container

Open plata opened this issue 7 years ago • 4 comments

Use APPLICATION_ID instead of application name in all calls of wine.prefix() (especially in QuickScripts).

pros:

  • "Notepad++" and "Notepad" can be installed in different containers
  • matching a container and an app is more straight forward (though this doesn't work in general - you can still use any container name you'd like)

cons:

  • container names become more unnatural ("Age_of_Empires_II" instead of "Age of Empires II")

plata avatar Mar 30 '18 08:03 plata

Can't we add an input to the the setup wizard, where the user can specify the container name? As default the setup wizard should then use APPLICATION_ID, but this provides the user the means to change it if he doesn't like this name.

madoar avatar Mar 30 '18 13:03 madoar

We could certainly do that but I see no benefit. Why should anybody dare to think about a container name? It only makes using Phoenicis more difficult because you would have to understand the concept of containers and the possible implications of choosing a container name (which is unnecessary and makes installing an app more complicated).

plata avatar Mar 30 '18 16:03 plata

Yes, you're right

madoar avatar Apr 06 '18 08:04 madoar

There's one flaw with the proposal (but also with the current implementation): It is not guaranteed (by design) that application IDs are unique. Only the triple of type ID, category ID and application ID is unique. The question is if we want to consider this for the container names or if we just assume that application ID is unique.

plata avatar Apr 07 '18 05:04 plata