scripts icon indicating copy to clipboard operation
scripts copied to clipboard

Update OnlineInstallerScript Default check wine settings

Open borinquenkid opened this issue 2 years ago • 6 comments

Description

Currently OnlineInstallerScript does not work correctly since it defaults to upstream and no version. Asking for wine settings configures correctly

What works

What was not tested

Test

  • Operating system (and linux kernel version):
  • Hardware (GPU/CPU):

Ready for review

  • [X] Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
  • [X] json-align and eslint run according to the documentation.
  • [ ] Codacy and travis checked.

borinquenkid avatar Jan 30 '23 02:01 borinquenkid

We cannot do it like this. The scripts should use the default or specify it via e.g.

.wineVersion(getLatestStagingVersion)
.wineDistribution("staging")

If the default version (latest stable) is not fetched correctly anymore, we must fix that. See https://github.com/PhoenicisOrg/scripts/blob/7eb38913dff8fcacbd5104ec6b3e247a0c5b7897/Engines/Wine/Engine/Versions/script.js#L79

plata avatar Jan 31 '23 16:01 plata

The upstream builds for Darwin do not work?

MacOS except for really old is all 64 bit, so x86on64 is only cx. If on an AMD64 machine they can switch by hand to amd64 engine.

borinquenkid avatar Feb 05 '23 23:02 borinquenkid

Could not figure out your exact implementation, but I hope this is acceptable

borinquenkid avatar Feb 05 '23 23:02 borinquenkid

I understand that the variables exist in QuickScript. However, the "versions" does not derive from it. And also the scripts are not necessarily QuickScripts, e.g.: https://github.com/PhoenicisOrg/scripts/blob/master/Applications/Internet/Internet%20Explorer%206.0/Online/script.js

plata avatar Feb 07 '23 21:02 plata

Please check https://phoenicisorg.github.io/scripts/General/tools/. Somehow the formatting got messed up.

plata avatar Feb 14 '23 15:02 plata

I ran ESLint

borinquenkid avatar Feb 16 '23 05:02 borinquenkid