scripts icon indicating copy to clipboard operation
scripts copied to clipboard

Published 20 hours ago • verified publisher icon PhoenicisOrg

Update Origin, using const instead of var and Resource instead of Downloader

Open Zemogiter opened this issue 5 years ago • 8 comments

Description

fix #1177

What works

to be filled in

What was not tested

Everything

Test

  • Operating system (and linux kernel version): Ubuntu 19.10
  • Hardware (GPU/CPU): GTX1080 ti, i7-7700K

Ready for review

  • [ ] Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
  • [ ] json-align and eslint run according to the documentation.
  • [ ] Codacy and travis checked.

Zemogiter avatar Jan 05 '20 13:01 Zemogiter

This PR should not contain "Heroes of Might & Magic IV".

plata avatar Jan 05 '20 13:01 plata

I don't know why there are files for Heroes 4 in this PR.

Zemogiter avatar Jan 05 '20 13:01 Zemogiter

Why is Travis stuck?

Zemogiter avatar Jan 05 '20 22:01 Zemogiter

Could be that it doesn't run on draft PRs.

plata avatar Jan 06 '20 18:01 plata

No it works on other draft releases. @Zemogiter please try pushing a change to the branch this should trigger a new build.

madoar avatar Feb 08 '20 13:02 madoar

@Zemogiter you have conflicts.

plata avatar Mar 02 '20 18:03 plata

@plata done

Zemogiter avatar Mar 03 '20 09:03 Zemogiter

@madoar did we come to any conclusion regarding Resource/Downloader now? In my opinion using Resource here is not correct.

plata avatar Mar 03 '20 17:03 plata