scripts icon indicating copy to clipboard operation
scripts copied to clipboard

Add Mf workaround

Open Zemogiter opened this issue 6 years ago • 13 comments

Description

A workaround for Media Foundation https://github.com/z0z0z/mf-install Needed for games that rely on it for ingame video and cutscenes. For example, benchmark videos in PC Building Simulator. After following instructions in the repo linked above, I can report they work just like on Windows now.

What works

Extracting the file, copying the dll files, setting dll overrides

What does not work

  • ~~dll override adds "native" to the name of the overriden dll not where it supoused to be~~ fixed by #1152
  • no entries from mf.reg are applied to the registry. Regedit plugin shows no errors

What was not tested

Everything after above mentioned

Test

  • Operating system (and linux kernel version): Ubuntu 19.10
  • Hardware (GPU/CPU):i7-7700K,GTX 1080ti

Ready for review

  • [ ] Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
  • [x] json-align and eslint run according to the documentation.
  • [ ] Codacy and travis checked.

Zemogiter avatar Dec 06 '19 01:12 Zemogiter

Output of eslint:

  79:68    error  Unnecessary escape character: \S  no-useless-escape
  79:77    error  Unnecessary escape character: \W  no-useless-escape
  79:82    error  Unnecessary escape character: \L  no-useless-escape
  79:576   error  Unnecessary escape character: \C  no-useless-escape
  79:582   error  Unnecessary escape character: \{  no-useless-escape
  79:675   error  Unnecessary escape character: \C  no-useless-escape
  79:681   error  Unnecessary escape character: \{  no-useless-escape
  79:720   error  Unnecessary escape character: \I  no-useless-escape
  79:795   error  Unnecessary escape character: \C  no-useless-escape
  79:801   error  Unnecessary escape character: \{  no-useless-escape
  79:888   error  Unnecessary escape character: \C  no-useless-escape
  79:894   error  Unnecessary escape character: \{  no-useless-escape
  79:933   error  Unnecessary escape character: \I  no-useless-escape
  79:1008  error  Unnecessary escape character: \C  no-useless-escape
  79:1014  error  Unnecessary escape character: \{  no-useless-escape
  79:1107  error  Unnecessary escape character: \C  no-useless-escape
  79:1113  error  Unnecessary escape character: \{  no-useless-escape
  79:1152  error  Unnecessary escape character: \I  no-useless-escape

Zemogiter avatar Dec 06 '19 01:12 Zemogiter

Why does this PR contain Applications/Games/Heroes of Might & Magic IV/miniatures/main.png?

plata avatar Dec 12 '19 17:12 plata

I don't know. I've created separate branches for both Heroes 4 and this PR from master.

Zemogiter avatar Dec 13 '19 09:12 Zemogiter

Can you fix it?

plata avatar Dec 16 '19 17:12 plata

Done

Zemogiter avatar Dec 17 '19 10:12 Zemogiter

These escape characters are needed because reg entries must be in separate lines.

Zemogiter avatar Dec 20 '19 11:12 Zemogiter

OP was updated

Zemogiter avatar Dec 24 '19 18:12 Zemogiter

Tried referencing the .reg file inside mfWorkaroundDir but the same issue happens.

        const regeditFile = `${prefixDirectory}/mfWorkaround/mf-install-master/mf.reg`
        new Regedit(this.wine).patch(regeditFile);

Zemogiter avatar Dec 25 '19 10:12 Zemogiter

By issue you mean that the .reg file is not modified?

madoar avatar Dec 29 '19 10:12 madoar

@Zemogiter patch requires two parameters to work, please see:

https://github.com/PhoenicisOrg/scripts/blob/93403d446bc8f0068eddd968fdfe99282df94fb5/Engines/Wine/Plugins/regedit/script.js#L39-L48

madoar avatar Dec 29 '19 10:12 madoar

By issue I mean the registry entries from mf.reg are not in registry editor.

Zemogiter avatar Dec 29 '19 10:12 Zemogiter

Has the regedit problem be solved or is it still work in progress?

madoar avatar Jan 03 '20 11:01 madoar

@madoar still work in progress

Zemogiter avatar Jan 03 '20 12:01 Zemogiter