scripts icon indicating copy to clipboard operation
scripts copied to clipboard

Remove "wizard" from the "preInstall" and "postInstall" Hooks of the Installer Scripts

Open madoar opened this issue 6 years ago • 1 comments

Currently we pass the two parameters wine (of type Wine) and wizard (of type SetupWizard) to the preInstall and postInstall hooks of the installer scripts. The wizard parameter is redundant because it can also be fetched from wine by calling wine.wizard() therefore we should remove it from both hooks. This will change the syntax of the two hooks to:

Installer.preInstall(wine => {
   ...
});

Installer.postInstall(wine => {
   ...
});

For more details see also https://github.com/PhoenicisOrg/scripts/pull/1117#discussion_r322877500

madoar avatar Sep 12 '19 18:09 madoar

When fixing this, don't forget documentation.

plata avatar Sep 16 '19 17:09 plata