Phobos icon indicating copy to clipboard operation
Phobos copied to clipboard

Enable and customize select boxes

Open NetsuNegi opened this issue 3 years ago • 14 comments

#600 Now you can use and custom a select box for infantry, vehicle and aircraft. Not support on buildings.

in rulesmd.ini

[AudioVisual]
UseSelectBox=no                                       ; (boolean)
SelectBox.Shape.Infantry=select.shp          ; (filename, includingthe .shp extension)
SelectBox.Palette.Infantry=palette.pal        ; (filename, includingthe .pal extension)
SelectBox.Frame.Infantry=0,0,0                  ; (frame, green hp, yellow hp, red hp)
SelectBox.DrawOffset.Infantry=0,0             ; (X, Y, positive value is right and down)
SelectBox.Shape.Unit=select.shp                ; (filename, includingthe .shp extension)
SelectBox.Palette.Unit=palette.pal              ; (filename, includingthe .pal extension)
SelectBox.Frame.Unit=3,3,3                        ; (frame, green hp, yellow hp, red hp)
SelectBox.DrawOffset.Unit=0,0                   ; (X, Y, positive value is right and down)
SelectBox.TranslucentLevel=0
SelectBox.CanSee=Owner               ; (AffectedHouse, who can see it, not include the observer)
SelectBox.CanObserverSee=true     ; (boolean)

Remember not for buildings!!!

[SOMETECHNO]
UseSelectBox=                                            ; (boolean, override the UseSelectBrd)
SelectBox.Shape=                                       ; (filename, includingthe .shp extension)
SelectBox.Palette=                                      ; (filename, includingthe .pal extension)
SelectBox.Frame=                                       ; (frame, green hp, yellow hp, red hp)
SelectBox.DrawOffset=                               ; (X, Y, positive value is right and down)
SelectBox.TranslucentLevel=
SelectBox.CanSee=                                     ; (AffectedHouse, who can see it, not include the observer)
SelectBox.CanObserverSee=                       ; (boolean)

You can also set it in ra2md.ini

[Phobos]
EnableSelectBox=false (boolean)

NetsuNegi avatar May 16 '22 13:05 NetsuNegi

It just fix a bug of SelectBrd.DrawOffset

NetsuNegi avatar May 16 '22 13:05 NetsuNegi

Nightly build for this pull request:

github-actions[bot] avatar May 22 '22 10:05 github-actions[bot]

Just for curiosity, why is called "UseSelectBrd" instead of "UseSelectBox" since the feature is called SelectBox ? :-/

FS-21 avatar Jun 04 '22 13:06 FS-21

Just for curiosity, why is called "UseSelectBrd" instead of "UseSelectBox" since the feature is called SelectBox ? :-/

For some reason I forgot that XD, I had rename this logic. Thanks for reminding.

NetsuNegi avatar Jun 04 '22 13:06 NetsuNegi

What's the status of this PR? @FS-21 said >since the last feedback but I can't see any feedback other than the UseSelectBox one?

Metadorius avatar Jul 01 '22 21:07 Metadorius

What's the status of this PR? @FS-21 said >since the last feedback but I can't see any feedback other than the UseSelectBox one?

Because I don't find anything to blame the author of the PR. Unless someone find some code improvement to me was ok (the code style)

FS-21 avatar Jul 01 '22 21:07 FS-21

Have you finished with the changes or not yet? I see some of my comments were unaddressed.

Metadorius avatar Jul 08 '22 13:07 Metadorius

Have you finished with the changes or not yet? I see some of my comments were unaddressed.

Yes, thoes are finished.

NetsuNegi avatar Jul 08 '22 13:07 NetsuNegi

Have you finished with the changes or not yet? I see some of my comments were unaddressed.

Yes, thoes are finished.

Well, you didn't address quite a bit of my comments. Fix the issues and then I'll review again.

Metadorius avatar Jul 08 '22 13:07 Metadorius

Please, go over ALL of the comments and address them one by one. If you don't understand what I mean then ask to clarify.

Has been supplemented.

ststl-s avatar Jul 20 '22 07:07 ststl-s

The phrase "Enable and custom select box" bothers me. Is it supposed to be "Enable customisable select box" or "Enable a custom select box"?

brsajo avatar Jul 31 '22 08:07 brsajo

The phrase "Enable and custom select box" bothers me. Is it supposed to be "Enable customisable select box" or "Enable a custom select box"?

You need enable it first, then you can custom the selectbox if you want.

NetsuNegi avatar Jul 31 '22 08:07 NetsuNegi

Okay so then to be grammatically correct it should be called "Enable and customize select boxes"

brsajo avatar Jul 31 '22 08:07 brsajo

Okay so then to be grammatically correct it should be called "Enable and customize select boxes"

OK, thank you.

NetsuNegi avatar Jul 31 '22 08:07 NetsuNegi

Every time I want to submit something else, I will be contaminated by it.GitHub is too complex to use for me

NetsuNegi avatar Jan 18 '23 01:01 NetsuNegi