Phobos icon indicating copy to clipboard operation
Phobos copied to clipboard

Fix of the legless cyborgs when leave transports

Open FS-21 opened this issue 3 years ago • 20 comments

And a new tag for enabling the old behavior, ideal for repair vehicles.

In the vanilla YR game legless Cyborgs recover legs when leave transports.

Summary by CodeRabbit

  • New Features
    • Introduced the ability for transports to repair legless cyborgs.
  • Bug Fixes
    • Fixed a bug that incorrectly restored cyborg legs when soldiers exited transports.
  • Documentation
    • Updated documentation to reflect new functionalities and bug fixes related to cyborg leg repairs.

FS-21 avatar Apr 02 '22 17:04 FS-21

Nightly build for this pull request:

github-actions[bot] avatar Apr 02 '22 17:04 github-actions[bot]

Omitted CanRepairCyborgLegs= tag from transport and cyborg legs were not reattached (1st image)

Added CanRepairCyborgLegs=true tag to transport and cyborg legs were reattached (2nd image)

https://imgur.com/a/MU3fW82

Interestingly damaged spark anims of cyborg constantly play, even if inside a transport.

AlliedG avatar Apr 09 '22 18:04 AlliedG

Looks related to OpenTopped logic because standard transports doesn't show sparks.

BUT from what I discovered in vanilla YR tests that "bug" is part of vanilla YR, not caused by this feature so we can consider that this " just works".

FS-21 avatar Apr 10 '22 15:04 FS-21

This no longer requires testing as the sparking in transport due to opentopped is expected? I see some errors with merging?

AlliedG avatar May 06 '22 23:05 AlliedG

Works. But as for me it's better to expand the funcional For example

1 [General] globally enable or disable the repair of cyborgs inside the transport (default - repair works)

2 [InfantryType] (cyborg=yes) add a pair of keys that prohibit or allow the cyborg to be repaired inside any vehicle (default - repairable)

3 [VehicleType] add a key to a unit that can repair a cyborg/cyborgs (you can try adding an enumeration). in this case, this priority will be higher than priority 2.

DmitryVolkov666 avatar May 10 '22 01:05 DmitryVolkov666

@FS-21 A friendly reminder to fix the issues.

Metadorius avatar Jul 01 '22 21:07 Metadorius

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

github-actions[bot] avatar Jul 22 '23 15:07 github-actions[bot]

[!NOTE] Currently processing new changes in this PR. This may take a few minutes, please wait...

Commits Files that changed from the base of the PR and between 01b4ab2a4e89b0848ff245a2e7e8de0fa10f5e48 and e746ba6dbb59a8f73fe155888c3d0bae0f162736.
Files selected for processing (9)
  • CREDITS.md (1 hunks)
  • docs/Fixed-or-Improved-Logics.md (1 hunks)
  • docs/New-or-Enhanced-Logics.md (1 hunks)
  • docs/Whats-New.md (2 hunks)
  • src/Ext/Techno/Body.cpp (1 hunks)
  • src/Ext/Techno/Body.h (2 hunks)
  • src/Ext/Techno/Hooks.cpp (2 hunks)
  • src/Ext/TechnoType/Body.cpp (2 hunks)
  • src/Ext/TechnoType/Body.h (2 hunks)
 ___________________________________________________
< Great artists ship, but not before a code review. >
 ---------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Mar 14 '24 15:03 coderabbitai[bot]