Minor Save fix

[secsome]

This PR has been already tested by hundreds of MO336 players which is known as Extra Save Fix in it, it provides fixes like: Map lighting get corrupted after load the save BuildOfAlly is reset after load the save

It also include a new trigger action called AdjustLighting which is more detailed. Which means you can choose to only update CellDrawers, Objects, and CustomPalettes. That has been tested already too, by many mappers like Sandman, Esther and so on.

[secsome]

This dll conflicts with the savefix dll in mo336, do not test them together.

[github-actions[bot]]

Nightly build for this pull request:

• compiled-dll-e7cdf955e790548ec861b61482ef7f4af4e1f6c2.zip This comment is automatic and is meant to allow guests to get latest nightly builds without registering. It is updated on every successful build.

[Metadorius]

@secsome add the damn docs and let's merge before 0.3 comes out ffs @chaserli may help with testing for example?

[chaserli]

@secsome add the damn docs and let's merge before 0.3 comes out ffs @chaserli may help with testing for example?

After the branch gets updated. I don't quite understand the code here.

[chaserli]

Which part is responsible for BuildOffAlly S/L fix? I don't quite get it Is it the serialization of SessionClass::Instance->Config?

[secsome]

Which part is responsible for BuildOffAlly S/L fix? I don't quite get it Is it the serialization of SessionClass::Instance->Config?

yes, .Process(SessionClass::Instance->Config) does the fix, as YR didn't do serialization on SessionClass, I decided to simply serialize it in ScenarioClass

[chaserli]

• BuildOffAlly S/L fix confirmed
• Lighting S/L issue seems to be fixed but

I didn't S/L at this moment, just after time-freeze, it became like this, where there's probably a light tint post at the center. It's gone after S/L, and I can not reproduce the issue on every new trial.

[secsome]

I cannot reproduce the issue you mentioned here.

This feature should have a tag to switch it on, I will add a tag later.

[Metadorius]

Err why exactly is the switch needed?

[chaserli]

Err why exactly is the switch needed?

I think it may refer to the issue I reported above, although I think it's actually not quite necessary

Even if you insist so, I would recommend setting the default value to yes unless shit happens

[secsome]

There are some existing maps set the lighting without the fix, if you don't give an option to disable the lighting fix, the existing maps will looks bad. So this is just a forward compatibility.

[Metadorius]

so what's the actual state😵

[secsome]

What needs to be tested:

1. Reveal All Command
2. BuildOfAlly
3. TAction 507 AdjustLighting
4. [Basic]>AdjustLightingFix