DebrisTypes=XXXX is invalid in Phobos v0.4 official release.

[Apieceofxiyz]

Description

voxel爆炸不会炸出碎片（DebrisTypes=XXXX无效），但是换到开发版build-48和47的voxel爆炸都正常 Voxel explosions do not produce debris (DebrisTypes=XXXX is ineffective), but switching to the development builds 48 and 47 resolves the issue.

Phobos Version

phobos v0.4

Conditions to reproduce

例如，原版游戏中击毁盟军矿车会爆出几个轮胎。但不修改任何配置，仅添加phobos v0.4后，击毁盟军矿车便不会爆出轮胎。 For example, destroying Allied harvester in the original game would drop several tires. However, without modifying any settings and simply adding Phobos v0.4, destroying Allied harvester will no longer drop tires.

INI code

[CMIN]
MaxDebris=6
DebrisTypes=TIRE
DebrisMaximums=4

Steps to reproduce

1. Run the original game and destroy the Allied Harvester to generate tire debris .
2. Install Phobos 0.4 Official Release.
3. Run the game and destroy the Allied Harvester; tire debris will not be generated at this point.

Expected behaviour

DebrisTypes=XXXX should take effect in phobos v0.4

Actual behaviour

DebrisTypes=XXXX didn't take effect in phobos v0.4

Additional context

No response

Checklist

• [x] The issue happens on the latest official version of Phobos and wasn't fixed yet.
• [x] I agree to elaborate the details if requested and provide thorough testing if the bugfix is implemented.
• [x] I added a very descriptive title to this issue.
• [x] I used the GitHub search and read the issue list to find a similar issue and didn't find it.
• [x] I have attached as much information as possible (screenshots, gifs, videos, debug and exception logs, etc).

[secsome]

The behavior has changed since build-47 to build-48, commit 4d6f7b47c57c646425468601c1f46872e87593d1 introduced this problem. As we shouldn't introduce more new feature in the release fix, the best solution is to revert the code thunk back in my view.

[secsome]

@Metadorius What do you think, create a branch release/v0.4.0.1 for bugfix and simply revert this thunk?

[Metadorius]

I think a hotfix release is in order, but I would prefer for more bugfixes to be accumulated before actually releasing it, so we don't end up with something like 0.4.0.10 eventually.

[secsome]

I agree with accumulate the bugfixes, I mean the way to fix it, should be just revert the related changes in the commit I mentioned above?

[Metadorius]

I mean, @CrimRecya is the author of the change, would be better to ask him.

[CrimRecya]

I agree with reverting https://github.com/Phobos-developers/Phobos/commit/4d6f7b47c57c646425468601c1f46872e87593d1 , the title and content of this commit are completely unrelated.

The real repair method comes from hook 0x74A70E in https://github.com/Phobos-developers/Phobos/commit/1f842e12c219617ae336ee435e9702f840cc7bdb, using pThis->Location as the voxel anims' generation location, but it was overlooked, and the logic of its modification to the vanilla behavior was unexpectedly retained (this unexpected modification was later restored in https://github.com/Phobos-developers/Phobos/commit/8bd666c277200bf28b3e76bc3ea739437540502d , but it seems to be considered as a new feature, so it was not added).

[Apieceofxiyz]

@CrimRecya It seems like 0.4.0.1 doesn't fix this bug. 貌似0.4.0.1没有解决这个bug