Phobos icon indicating copy to clipboard operation
Phobos copied to clipboard

Reduce floating point precision

Open chaserli opened this issue 9 months ago • 6 comments

Do you really need that precision?

chaserli avatar Mar 11 '25 15:03 chaserli

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

github-actions[bot] avatar Mar 11 '25 15:03 github-actions[bot]

with nightly from this pull request we've experienced 6 crashes so far, while 4 of them are sudden quit that didn't generate anything other than debug.log. Uploaded these logs here, not sure if it's related to the floating point change

Version: MO 3.3.6 + edits for new Phobos logic testing Fatal Errors.zip

Coronia avatar Mar 17 '25 11:03 Coronia

This just needs testing. No idea about consequences.

I am simply asking about which /fp option to use. As far as I know, there are not a great many FP operations in the current Phobos. However, if someone intends to rewrite some low level features, it could be an important factor. Although I've been using this option over the last 2 years, I'm not sure about its potential risks. Therefore, I am raising this question in advance to see if anyone has an answer. Before that, just hold this for a while. I compiled ddraw with avx and /fp:fast to take some advantage of simd operations, yet the effect is limited because of its narrow application scope.

with nightly from this pull request we've experienced 6 crashes so far, while 4 of them are sudden quit that didn't generate anything other than debug.log. Uploaded these logs here, not sure if it's related to the floating point change

Alphaimage/blitter crashes should already be present before

chaserli avatar Mar 19 '25 10:03 chaserli

with nightly from this pull request we've experienced 6 crashes so far, while 4 of them are sudden quit that didn't generate anything other than debug.log. Uploaded these logs here, not sure if it's related to the floating point change

I did few games against AI and didn't encounter any crashes. Also tried MO and no crashes either (although i will still try to play the campaign more). Perhaps those crashes are caused by ddraw.dll?

mevitar avatar Mar 25 '25 21:03 mevitar

SCRN 20250413-152906-00737

Had this graphical problem when loading a MO campaign save. It fixed itself only when i loaded the game again. Not sure if it's related to ddraw i'm using or because of this build. That game also crashed to desktop when i was close to finishing the mission. Only syringle.log and debug.log were created, as except.txt got dumped into syringe.log:

250413-todesktop_b1572.zip

mevitar avatar Apr 13 '25 14:04 mevitar

so far we don't have much odd occured when testing this. The above crashes didn't appear in later test either

Coronia avatar Jun 09 '25 08:06 Coronia