Phobos-developers
[Minor] Make quick save happens after main loop
According to what ZivDero told me, saving game inside the main loop may cause corruption. So we need to move it out of the main loop.
This needs to be used together with the unmerged yrpp-spawner feature to work properly.
It needs to be discussed about how we should interact with spawner. Maybe a flag like CanUseSpawner or sth alike.
Open a draft PR to keep this in mind.
Nightly build for this pull request:
- compiled-dll-5ad6208eb45e15377d649922a81b1405435d2d3b.zip These artifacts will expire in 90 days and will not be available for download after that time.
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Is there a reason this is a draft?
Currently, this one can not work correctly without the unmerged AutoSave feature of the spawner. Because the event handling of SaveGame in vanilla is somehow broken. As the spawner rewrote the event handling, I'm not sure what we are going to do with this one. Maybe we need a CanUseSpawner flag to check if the spawner is present, but I dunno how to add it for now.
@TaranDahl We have two ways of dealing with that:
- Copy the relevant parts from the spawner here so that if any of the spawner and Phobos are present - it works.
- Move the quick save command to the spawner.
What do you and others think?