Phobos icon indicating copy to clipboard operation
Phobos copied to clipboard

[Minor] Clear jumpjets' redundant destination

Open CrimRecya opened this issue 1 year ago • 1 comments

Clear jumpjets' redundant Destination and queue their missions into Guard, when they change state to hovering. This is for improving align jumpjet turret's facing with body's, and adapt to #1308 .

CrimRecya avatar Oct 17 '24 19:10 CrimRecya

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

github-actions[bot] avatar Oct 17 '24 19:10 github-actions[bot]

I'm not sure about this, force queuing guard mission without target check seems a bit radical and I already observed something a bit weird. That comment of mine was made 2+ years ago and I somehow doubt it now, I may need some explanation/confirmation.

I have removed unnecessary queue guard mission. Everything I have done here is just to clear the jumpjet's Destination when it has arrived at its destination, just like others.

CrimRecya avatar Oct 28 '24 09:10 CrimRecya

Why was the PR closed?

Metadorius avatar Nov 01 '24 15:11 Metadorius

Why was the PR closed?

Oh, actually, I just learned about a phenomenon about some jumpjets that cannot attack while moving will get stuck in the move mission without destination and allow enemies to pass underneath them. I haven't thought of any good solutions yet.

CrimRecya avatar Nov 01 '24 15:11 CrimRecya