Phobos icon indicating copy to clipboard operation
Phobos copied to clipboard

[Minor] Shield respawn anim and weapon

Open Coronia opened this issue 1 year ago • 6 comments

  • Respawn.Anims, if set, will be played when the shield respawns. If more than one animation is listed, a random one is selected.
  • Respawn.Weapon, if set, will be fired at the TechnoType once the shield respawns.
  • If Respawn.RestartInCombat is set, respawn timer pauses and then resumes after Respawn.RestartInCombatDelay frames have passed when the TechnoType has a shield that's under respawn process.
  • Shield.Respawn.Anims and Shield.Respawn.Weapon override Respawn.Anims and Respawn.Weapon for duration of Shield.Respawn.Duration amount of frames.
  • Additionally Shield.Respawn.RestartInCombat & Shield.Respawn.RestartInCombatDelay can be used to override ShieldType settings.

In rulesmd.ini:

[SOMESHIELDTYPE]                            ; ShieldType name
Respawn.RestartInCombat=true                ; boolean
Respawn.RestartInCombatDelay=0              ; integer, game frames
Respawn.Anim=                               ; list of Animation
Respawn.Weapon=                             ; WeaponType

[SOMEWARHEAD]                               ; WarheadType
Shield.Respawn.RestartInCombat=             ; boolean
Shield.Respawn.RestartInCombatDelay=-1      ; integer, game frames
Shield.Respawn.Anim=                        ; list of Animation
Shield.Respawn.Weapon=                      ; WeaponType

Coronia avatar Sep 16 '24 10:09 Coronia

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

github-actions[bot] avatar Sep 16 '24 11:09 github-actions[bot]

I propose to add a common template/composite tag like Promotable to which people can assign whatever they want - anim, weapon or whatever. The point is that we can reuse this template anywhere and easily add a lot of events, all consistently.

And this template does what exactly?

Starkku avatar Sep 16 '24 13:09 Starkku

I propose to add a common template/composite tag like Promotable to which people can assign whatever they want - anim, weapon or whatever. The point is that we can reuse this template anywhere and easily add a lot of events, all consistently.

And this template does what exactly?

Almost-one-liner for modders to add whatever amounts of event handling possibilities for any "event" in a consistent fashion, like I do have those in techno attachment and I can just use the template. Further on it can be expanded to add whatever event handling possibilities if needed. image

Metadorius avatar Sep 16 '24 13:09 Metadorius

@Coronia do you need any assistance on what I proposed? You can refer to #1304 for an example of the new template and bother me here or in Discord to help.

Metadorius avatar Nov 11 '24 07:11 Metadorius

Yeah I would be appreciated if there's a demo for this. I've looked into the pull request but not quite got it yet. I take it that we should define MultiFlag for weapon and use it here, but still not sure how to do it correctly. If there's an existed template for weapon it would be better, and if my understanding is wrong please correct me.

Coronia avatar Nov 12 '24 02:11 Coronia

[!CAUTION]

Review failed

An error occurred during the review process. Please try again later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 09 '25 08:04 coderabbitai[bot]