Phobos icon indicating copy to clipboard operation
Phobos copied to clipboard

Fix Insignia.Weapon failed to parse in map & Insignia.Passengers

Open Coronia opened this issue 1 year ago • 1 comments

previous Insignia(.Frame/.Frames).WeaponN settings can't be read or overridden from maps, which is fixed now

also added insignia based on current passenger size: Normal insignia can be overridden when its current passenger size reaches a certain amount by setting Insignia(.Frame/.Frames).PassengersN where N stands for the current passenger size amount. If not set, defaults to non-passenger specific insignia settings. Will be overridden by weapon mode insignia settings, if set.

In rulesmd.ini:

Insignia.PassengersN=                    ; filename - excluding the .shp extension
Insignia.PassengersN.Rookie=             ; filename - excluding the .shp extension
Insignia.PassengersN.Veteran=            ; filename - excluding the .shp extension
Insignia.PassengersN.Elite=              ; filename - excluding the .shp extension
InsigniaFrame.PassengersN=-1             ; int, frame of insignia shp (zero-based) or -1 for default
InsigniaFrame.PassengersN.Rookie=-1      ; int, frame of insignia shp (zero-based) or -1 for default
InsigniaFrame.PassengersN.Veteran=-1     ; int, frame of insignia shp (zero-based) or -1 for default
InsigniaFrame.PassengersN.Elite=-1       ; int, frame of insignia shp (zero-based) or -1 for default
InsigniaFrames.PassengersN=-1,-1,-1      ; int, frames of insignia shp (zero-based) or -1 for default

Coronia avatar Aug 25 '24 06:08 Coronia

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

github-actions[bot] avatar Aug 25 '24 06:08 github-actions[bot]

image Since there're tons of tags for Insignia already, I'm thinking of removing the old tags for Passengers while only keeping its InsigniaType, would like some feedbacks from others to see if that's proper tho

Also @Metadorius could you list what should be modified for Insignia Type at here again, now that the old pull request has been closed?

Coronia avatar Feb 25 '25 08:02 Coronia