Phobos icon indicating copy to clipboard operation
Phobos copied to clipboard

[Minor] Fix AltNextScenario= not taking effect

Open Fly-Star-him opened this issue 1 year ago • 6 comments

An extension to “AltNextScenario=” has been made so that it can now be started with any variable with the name “<Alternate Next Scenario>”, but of course the original hardcoding still works.

Fly-Star-him avatar Jul 22 '24 12:07 Fly-Star-him

image

Hey, why is this showing up with a display error.

and how it should generate a nightly.

Fly-Star-him avatar Jul 22 '24 12:07 Fly-Star-him

I don't know if you are referring to issue #1108 and #1140, if yes then check if dde700f fixed it already

chaserli avatar Jul 22 '24 14:07 chaserli

I don't know if you are referring to issue #1108 and #1140, if yes then check if dde700f fixed it already

确实有用,那我只留下AltNextScenario=这部分修复就行了。

Machine translation: It does work, so I'll just leave the AltNextScenario= part of the fix.

Fly-Star-him avatar Jul 22 '24 14:07 Fly-Star-him

if the variables are not supposed to be editted in the function, we'd better avoid using reference here. Namely LocalVariables, GlobalVariables and their itr

I'm sorry, I don't quite understand.

Fly-Star-him avatar Aug 15 '24 15:08 Fly-Star-him

if the variables are not supposed to be editted in the function, we'd better avoid using reference here. Namely LocalVariables, GlobalVariables and their itr

I'm sorry, I don't quite understand.

auto const& LocalVariables = ScenarioExt::Global()->Variables[false]; auto const& GlobalVariables = ScenarioExt::Global()->Variables[true]; I didn't notice any edit on these 2 variables in this pull request. It's just iterating them and reading their values, so maybe the reference sign & could be removed. Same for auto const& itr

Coronia avatar Aug 15 '24 15:08 Coronia

if the variables are not supposed to be editted in the function, we'd better avoid using reference here. Namely LocalVariables, GlobalVariables and their itr

I'm sorry, I don't quite understand.

auto const& LocalVariables = ScenarioExt::Global()->Variables[false]; auto const& GlobalVariables = ScenarioExt::Global()->Variables[true]; I didn't notice any edit on these 2 variables in this pull request. It's just iterating them and reading their values, so maybe the reference sign & could be removed. Same for auto const& itr

if the variables are not supposed to be editted in the function, we'd better avoid using reference here. Namely LocalVariables, GlobalVariables and their itr

I'm sorry, I don't quite understand.

auto const& LocalVariables = ScenarioExt::Global()->Variables[false]; auto const& GlobalVariables = ScenarioExt::Global()->Variables[true]; I didn't notice any edit on these 2 variables in this pull request. It's just iterating them and reading their values, so maybe the reference sign & could be removed. Same for auto const& itr

got it.

Fly-Star-him avatar Aug 15 '24 15:08 Fly-Star-him

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

github-actions[bot] avatar Mar 07 '25 07:03 github-actions[bot]