Fix VoiceDeploy not playing when deploying through hot-key/command bar.

[Fryone]

VoiceDeploy now plays when 1 unit is ordered to deploy through hot-key/command bar.

Summary by CodeRabbit

• Bug Fixes
  • Fixed an issue where the deployment sound was not played when using hot-key/command bar for VoiceDeploy.
• New Features
  • Added audio feedback for player actions through VoiceDeploy feature.

[github-actions[bot]]

Nightly build for this pull request:

• compiled-dll-36e4dca152b311c9a05cd7343048b088997873a3.zip These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[mevitar]

This crashes when deploying infantry through a hotkey. Deploying through clicking works fine. Vehicles deploy properly through hotkey and clicking.

[mevitar]

Doesn't crash now.

[Belonit]

@mevitar, could you test this again. If everything is fine, I would like to merge this

[mevitar]

Doesn't work for infantry anymore.

[coderabbitai[bot]]

Walkthrough

This update introduces a fix for the VoiceDeploy feature, which ensures that sound is played when units are deployed using a hot-key or the command bar. A new hook, DeployCommandClass_Execute_VoiceDeploy, has been added to handle the voice deployment based on unit type and deployment status, improving the audio feedback for player actions and enhancing the user experience.

Changes

File	Summary
CREDITS.md	Added a fix for VoiceDeploy via hot-key/command bar in the project.
docs/Fixed-or-Improved-Logics.md	Fixed an issue with VoiceDeploy sound not playing on hot-key/command bar deployment.
src/Ext/Techno/Hooks.Misc.cpp	Added DeployCommandClass_Execute_VoiceDeploy hook for voice deployment based on conditions.

🐰✨
In the realm of code, where the bits align,
A rabbit hopped through, making sound shine.
With a flick and a hop, a fix was deployed,
Now every command, audibly enjoyed.
Hear the units march, at the press of a key,
A symphony of war, in digital spree.
🎶🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.