Phobos icon indicating copy to clipboard operation
Phobos copied to clipboard

Cloak Enchancement

Open NetsuNegi opened this issue 2 years ago • 13 comments

In rulesmd.ini:

[CombatDamage]
Cloak.KickOutParasite=true     ; boolean, can a unit kick out its parasite on cloaking/decloaking?

[AudioVisual]
CloakAnim=animation            ; Animation, will be played when cloaking starts
DecloakAnim=animation          ; Animation, will be played when decloaking starts

[SOMETECHNO]                   ; TechnoType
CloakAnim=animation            ; Animation, will be played when cloaking starts
DecloakAnim=animation          ; Animation, will be played when decloaking starts
Cloak.KickOutParasite=true     ; boolean, override of the same setting in [CombatDamage]

NetsuNegi avatar Jul 04 '23 00:07 NetsuNegi

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

github-actions[bot] avatar Jul 04 '23 00:07 github-actions[bot]

did someone test this ?

NetsuNegi avatar Jul 04 '23 04:07 NetsuNegi

Animations seem to work fine, for inherent and warhead-induced cloak. Haven't tried parasites.

mevitar avatar Jul 08 '23 09:07 mevitar

Please add a credits, documentation and "What's New" entry. I've already edited the description to match the current INI documentation standard.

Left a few comments and one question about a peculiar pointer access.

I'll fix docs tomorrow

NetsuNegi avatar Jul 08 '23 16:07 NetsuNegi

A minor nitpick: in the documentation, the comments about tag entries aren't perfectly aligned like they are for other tags.

mevitar avatar Jul 09 '23 12:07 mevitar

A minor nitpick: in the documentation, the comments about tag entries aren't perfectly aligned like they are for other tags.

fixed

NetsuNegi avatar Jul 09 '23 12:07 NetsuNegi

fixed

Not for the english version, though. :P

mevitar avatar Jul 09 '23 12:07 mevitar

Maybe my browser simply didn't update its cache last time, but now it looks properly even for the english version.

mevitar avatar Jul 09 '23 13:07 mevitar