measurement.js icon indicating copy to clipboard operation
measurement.js copied to clipboard

- Added days, weeks, years to duration conversion. (Julian Spec)

Open andrewvy opened this issue 11 years ago • 3 comments

Added days, weeks, years to duration conversion. Following the Julian calendar. (1 year = 365.25 days)

Also, updated README.md to include mass conversions.

andrewvy avatar Jun 02 '14 00:06 andrewvy

Let me medidate a bit over this - i'm not sure the scope of measurement.js is for datetime stuff - at least not in the core (right now i don't want to re-build). Maybe this should better be in a pluggable file mechanism as planned for 0.3, see roadmap.

Also - pls make sure not to send PRs to versioned branches going forward, as they should always contain the released state, so either create a seperate one or send the PR to master. I will then merge into the versioned branch right before release.

But anyway keep on the contributions ;) Thanks heaps!

Philzen avatar Jun 04 '14 12:06 Philzen

Right! This is one of the first few pull requests that I've contributed to an open source project, so I'm not quite sure of the formalities.

I'll take a look at the roadmap and see what else I can take on.

andrewvy avatar Jun 04 '14 21:06 andrewvy

This is one of the first few pull requests that I've contributed to an open source project, so I'm not quite sure of the formalities.

No worries - the formalities are up to the maintainer to put into the readme under a "contribution guidelines" section, so it's actually my bad here ;)

Philzen avatar Jun 05 '14 11:06 Philzen