Philippe Dumonet

Results 50 comments of Philippe Dumonet

> It will cause problems in using ```vm.etch```. It does not deal well with address values in a range of [1-10](https://github.com/foundry-rs/foundry/issues/1159). > > What does that have to do with...

> Suggested here. [#559 (review)](https://github.com/Uniswap/v4-core/pull/559#pullrequestreview-1982030657) Oh yeah, missed that although my implementation in #625 is more optimized than the suggested implementation in #559

> > Is there any way to get around this error? > > Build locally! That doesn't seem to work either, cloning and running `cargo install --path ./crates/cli` gives the...

Hey, thanks for tagging @Maddiaa0. Exciting to see my BALLS in use. 😁

Been waiting for this feature forever! What do reverts look like? Is it able to give you the line you reverted on? What about solidity native functions like `abi.encode`, `require`?...

Hey @klkvr, great work on this PR! Just wanted to follow up on your comment about source maps getting messed up by the optimization step: do you mean that they're...

Don't really have that much experience with tree-sitter, are there any good resources you could point to that could help me debug this locally? Is syntax highlighting working for you...

I use `nvim-treesitter` with the config option `ensure_installed`. Running `:TSUpdate` tells me that "all parsers are up-to-date!"

I definitely think the compiler should raise an error here, duplicate label definitions should not be allowed. Huff also won't throw an error if you accidentally declare a duplicate label...

Isn't this already possible with `__codesize(MAIN)` and `__codesize(CONSTRUCTOR)`? Would be cool to have a built-in for the sum of the two tho i.e. deploy code, which would be very useful...