Phil Beauvoir

Results 821 comments of Phil Beauvoir

I'll be submitting a draft PR for discussion soon.

@azoitl I created PR https://github.com/eclipse/gef-classic/pull/132 for discussion. This is what I use in Archi. There may be a better way to do it. At the very least it is all...

@azoitl Thanks for looking at the PR. > The changes in PrinterGraphics changes the API or? This is in class `PrintOperation`. Because the `Graphics` intance can now be either `SWTGraphics`...

Hi @azoitl - thanks so much for taking this further. > Not sure if it is the best approach but wanted to get your opinion on it. Well, it certainly...

Hi @azoitl I'm not sure if it's the same issue but I discovered many years ago that a font for a Draw2d `IFigure` can be too big on Windows if...

@azoitl 1. I made my version of `Thumbnail` configurable to allow/ not allow scaled graphics, but the quality of the thumbnail is not very high anyway so I'm not sure...

> The only open point of I correctly remember is to fix the printing. PR can be used as a starting point, please feel free to make any changes... https://github.com/eclipse/gef-classic/pull/237

The problem is here: https://github.com/eclipse/gef-classic/blob/586bead1bb52bba21210349ab6be90d4f11780aa/org.eclipse.gef/src/org/eclipse/gef/SharedCursors.java#L56-L74 On Mac and Linux X11 the device zoom for cursors should always be 100. On Windows and Linux Wayland the device zoom for cursors should...

So a check needs to added in `getDeviceZoom` to return 100 if on Mac or Linux X11.

Created PR https://github.com/eclipse/gef-classic/pull/356