flutter_reactive_ble icon indicating copy to clipboard operation
flutter_reactive_ble copied to clipboard

Published 20 hours ago • verified publisher icon PhilipsHue

Fix missing typed_data import

Open rfuerst87 opened this issue 1 year ago • 2 comments

Fixes #649 and probably also #653.

rfuerst87 avatar Dec 14 '22 09:12 rfuerst87

No idea why Ble Workflow is failing. Quality checks run just fine on my machine. Unfortunately I do not have access to codemagic logs. Could the checked in pubspec.lock files cause problems? See #652 and #655.

rfuerst87 avatar Dec 14 '22 10:12 rfuerst87

Ok, turns out flutter 3.3.0 explicitly exports Uint8List from dart:typed_data in package:flutter/foundation.dart. I'm not really sure whether the compatibility break was intentional or not. As you removed the imports I did set minimum requirements for flutter to 3.3.0. See this PR from flutter: https://github.com/flutter/flutter/pull/105648

Another option would be to add the imports again and advise the linter to ignore unnecessary imports using // ignore: unnecessary_import. Anyway, at some point you probably want to get rid of the imports.

Let me know what you prefer. I'll update the PR accordingly.

rfuerst87 avatar Dec 14 '22 14:12 rfuerst87