elastic4s icon indicating copy to clipboard operation
elastic4s copied to clipboard

ODFE support and path forward with fork

Open KadekM opened this issue 4 years ago • 6 comments

Due to licensing changes in ES, the OpenDistroForElastic will fork last viable ES (7.10) , and since 7.11 is already out they will probably start diverging soon.

I don't suppose you plan to maintain patches for 7.10 in meantime and in any fashion support both DBs? If not I may just have to fork this and maintain it for ODFE. What do you think?

KadekM avatar Feb 16 '21 15:02 KadekM

I will probably support both (if both are popular) but I want to see what happens with ODFE first. Will it succeed or fizzle out. I remember when Hudson/Jenkins was forked and Hudson kind of died out. Mabye ODFE will take over and original ES will die out.

In other words, I'm delaying any decisions until I see what happens over the next month or three. I've also got to do this at the same time as adding dotty support.

But rest assured, I won't ignore ODFE if it takes off.

I'd be happy for anyone to join as a contributor here, regardless of how we proceed.

sksamuel avatar Feb 16 '21 16:02 sksamuel

Sounds good. So the plan is to have a separate branch for 7.10 release so we can patch it as well in meantime? I'm happy to help out with any further changes

KadekM avatar Feb 16 '21 18:02 KadekM

Yes we could do. I guess the only difference right now is the client dependency ? We could even move the elastic dependency to another module and make it opt in - it's only a HTTP client after all.

sksamuel avatar Feb 16 '21 18:02 sksamuel

I haven't tracked the changelog yet. But I guess in future there'll be more breaking changes so it's something we need to think of.

KadekM avatar Feb 16 '21 22:02 KadekM

I've been reading about it here: https://discuss.opendistrocommunity.dev/c/forking-elasticsearch-kibana/50 So once they have something released we can branch 7.10 for that.

sksamuel avatar Feb 18 '21 17:02 sksamuel

I don't see much action in the odfe fork at the moment.

sksamuel avatar Mar 24 '21 13:03 sksamuel