keepass2android icon indicating copy to clipboard operation
keepass2android copied to clipboard
verified publisher icon PhilippC

QuickFix Format_Badbase64Char #2953

Open lordyavin opened this issue 5 months ago • 3 comments

Add error handling for Convert.FromBase64String to not crash in case of bad format.

lordyavin avatar Jul 24 '25 06:07 lordyavin

May fix #2953

lordyavin avatar Jul 24 '25 06:07 lordyavin

TBH I'm pretty concerned with this fix as it silently swallows the invalid data. ReadBase64 is such a basic method that it's hard to decide what to do with invalid data here.

PhilippC avatar Jul 29 '25 14:07 PhilippC

TBH I'm pretty concerned with this fix as it silently swallows the invalid data. ReadBase64 is such a basic method that it's hard to decide what to do with invalid data here.

It's a quick fix and not a sophisticated error handling solution. You may handle it differently and show a dialog to the user which explains the problem and where it is. IMHO not opening the DB is very inconvenient.

lordyavin avatar Jul 29 '25 15:07 lordyavin