acf-pro-installer icon indicating copy to clipboard operation
acf-pro-installer copied to clipboard

Doesn't work with plugin Hirak/prestissimo

Open mickaelperrin opened this issue 8 years ago • 12 comments

When using this plugin in conjunction with hirak/prestissimo, the download of acf-pro fails because the custom RemoteFileSystem is overwritten. In order to get it working, we should ensure that this plugins runs after hirak/prestissimo. As both are running with a priority set to 0, setting this one to -1 resolves the issue.

mickaelperrin avatar Aug 16 '17 14:08 mickaelperrin

Can we please get this integrated?

partounian avatar Sep 11 '17 04:09 partounian

Thank you @mickaelperrin for your research and for submitting a pull request to solve the issue! ☺️ Sorry for the late answer, I was pretty busy lately 😞 Would you be so kind to adapt the failing test to reflect the new requirements? Let me know if you need help with that (the PHPUnit Manual can be handy resource).

Thank you again ☺️

PhilippBaschke avatar Sep 12 '17 19:09 PhilippBaschke

Can't wait until this being merged T_T

tucq88 avatar Sep 13 '17 08:09 tucq88

I suggest someone forks this project and updates it

partounian avatar Oct 13 '17 19:10 partounian

Could you merge this @PhilippBaschke ?

tucq88 avatar Oct 14 '17 08:10 tucq88

Just had to remove prestissimo for this one.

cooperaj avatar Feb 09 '18 14:02 cooperaj

@PhilippBaschke: +1 Also had an issue with hirak/prestissimo. After uninstalling it works.

strarsis avatar Apr 14 '18 13:04 strarsis

@PhilippBaschke: Are there plans for merging this in the near future? Just had this issue again.

strarsis avatar Jul 12 '18 17:07 strarsis

Same. Get it every two weeks everytime I start a new project... 😭

davidwebca avatar Jul 12 '18 19:07 davidwebca

@randmanrjr: Have you (still) write access to this repository? Could you merge this in (and publish a new release to packagist)?

strarsis avatar Jul 12 '18 21:07 strarsis

@strarsis I don't have write access to this repository. In the past, I made a small contribution via a pull request.

randmanrjr avatar Jul 13 '18 10:07 randmanrjr

Strange, I just tried it with hirak/prestissimo installed and it worked. 😕

strarsis avatar Aug 09 '18 21:08 strarsis