Philip May
Philip May
@SuperQ what do you think?
> another PR to remedy is in https://github.com/hwchase17/langchain/pull/3385, but I believe that is not tacking the core problem. I agree. This PR is a good solution to the problem. IMO...
> Doesn't fix the problem for me IMO the solution for this problem should be two measures: 1. adapt the prompt to reduce the probability that the SQL is in...
I am not 100% sure if this locale solution (`@staticmethod` in `SQLDatabaseChain`) is the right solution. Are there more places where this kind of normalization is needed or even implemented?...
This is ready for review please.
Hi @anabranch > If I read your implementation right, it remove the final ' from the query, even though it should keep it. That is not right. The code below...
@anabranch I added a test for this case: https://github.com/telekom/langchain/blob/738df5ce20ec75d30af166580d8a1318895370c4/tests/unit_tests/chains/test_sql_database.py#L33
@hwchase17 can you please approve the workflows?
> @hwchase17 can you please approve the workflows? Thanks. Ok. So checks are green. IMO this can be merged. :-)
> I'm not sure, but to me the problem is that the prompt template is wrong in asking for an SQL-statement with quotes. I think it is better to just...