BoilR icon indicating copy to clipboard operation
BoilR copied to clipboard

Multiple issues with the way BoilR handles existing imports

Open ubergeek77 opened this issue 3 years ago • 6 comments

There are two issues with the way BoilR handles existing games that have already been imported via BoilR:

  • If an existing game is un-checked when importing new games, the un-checked games will be removed from Steam
  • If an existing game is left checked when importing new games, BoilR will remove it anyway and effectively re-import it.

This is problematic, because it makes it impossible to maintain any changes to BoilR-imported games that have been made from Steam (either changing images on the Steam side or changing the game's launch parameters).

Given the current phrasing of the BoilR UI, the first case is also unexpected behavior - when I uncheck a game, I expect BoilR to ignore it, not remove it. The current behavior of BoilR would be more appropriately titled "Games to Show in Steam (Uncheck to Hide)."

I propose a single change to BoilR to resolve both these issues:

When a game is un-checked during a BoilR import, if it exists in Steam already, leave the existing entry in Steam completely alone - do not re-import it, do not change its images, and do not change its launch parameters. Effectively ignore it.

If this change is made to BoilR, the first two use cases I discussed would now look like this:

  • If an existing game is un-checked when importing new games, BoilR makes no changes to the game and no external modifications are lost.
  • If an existing game is left checked when importing new games, in keeping consistent with the title of this UI, BoilR will treat it as a NEW import, removing the existing entry and re-importing it, thus losing any changes.

To make the second case less prone to accidentally losing user changes, I would additionally suggest that already-imported titles be un-checked by default, rather than the current behavior of showing those games as checked.

Thanks for your consideration!

ubergeek77 avatar Jul 03 '22 03:07 ubergeek77

This is an interesting take on how to import. I have to think a bit about the pros and cons.

Have you seen the disconnect feature meanwhile? It does pretty much what you describe.

On Sun, Jul 3, 2022, 05:25 ubergeek77 @.***> wrote:

There are two issues with the way BoilR handles existing games that have already been imported via BoilR:

  • If an existing game is un-checked when importing new games, the un-checked games will be removed from Steam
  • If an existing game is left checked when importing new games, BoilR will remove it anyway and effectively re-import it.

This is problematic, because it makes it impossible to maintain any changes to BoilR-imported games that have been made from Steam (either changing images on the Steam side or changing the game's launch parameters).

Given the current phrasing of the BoilR UI, the first case is also unexpected behavior - when I uncheck a game, I expect BoilR to ignore it, not remove it. The current behavior of BoilR would be more appropriately titled "Games to Show in Steam (Uncheck to Hide)."

I propose a single change to BoilR to resolve both these issues:

When a game is un-checked during a BoilR import, if it exists in Steam already, leave the existing entry in Steam completely alone - do not re-import it, do not change its images, and do not change its launch parameters. Effectively ignore it.

If this change is made to BoilR, the first two use cases I discussed would now look like this:

  • If an existing game is un-checked when importing new games, BoilR makes no changes to the game and no external modifications are lost.
  • If an existing game is left checked when importing new games, in keeping consistent with the title of this UI, BoilR will treat it as a NEW import, removing the existing entry and re-importing it, thus losing any changes.

To make the second case less prone to accidentally losing user changes, I would additionally suggest that already-imported titles be un-checked by default, rather than the current behavior of showing those games as checked.

Thanks for your consideration!

— Reply to this email directly, view it on GitHub https://github.com/PhilipK/BoilR/issues/173, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEE7DAS2TXX6YXZUOTYGGTVSEBYZANCNFSM52P7YZUQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

PhilipK avatar Jul 03 '22 06:07 PhilipK

To be honest, no, I completely missed that feature :)

This should be good enough for now. I will have to remember to do this every time I add a new game. Hopefully in the future this will not be required.

Thanks for your work on BoilR! I cannot imagine how much work it would be to get images onto my non-Steam games without it, so I appreciate that you made this.

ubergeek77 avatar Jul 03 '22 06:07 ubergeek77

Glad it is helpful! I wonder if it would make sense to have an option in settings, that disconnects shortcuts right after they are imported? That way you can turn that setting on and BoilR wont touch the shortcut again after initial import.

PhilipK avatar Jul 04 '22 13:07 PhilipK

Is it okay if I close this issue? Since there is the "Disconnect" feature?

PhilipK avatar Jul 24 '22 19:07 PhilipK

Sure! Though, I do think a tooltip or something that warns the user that they are about to replace an existing import might increase clarity!

ubergeek77 avatar Jul 24 '22 19:07 ubergeek77

I think you can use the classic 3-way checkbox. Unchecked: do not import Checked: import Checked with minus symbol: remove

frontend developer here :D

nerdosity avatar Nov 04 '22 16:11 nerdosity