Notes-up icon indicating copy to clipboard operation
Notes-up copied to clipboard

Asterisk italics not shown correctly in note preview text

Open aljelly opened this issue 6 years ago • 5 comments

Steps to reproduce:

  1. Create a new note
  2. Copy and paste the following into it:
# Asterisk italics issue
_works_ and *doesn't work*
  1. Press Ctrl + S to save and update the note list

Should look like:

works and doesn't work

What actually appears:

works and *doesn't work*

aljelly avatar Mar 15 '18 16:03 aljelly

Bold in markdown is done with two Asterisks, not one :) Both the help panel and the toolbar add two asterisks so i'm going to mark this as working as intended

Philip-Scott avatar Mar 15 '18 16:03 Philip-Scott

I'm not talking about bold, I'm talking about italics.

In Markdown, one asterisk is valid as italics. *hello* = hello

Same with bold and two underscores: __hello__ = hello

It's the number of characters, not the characters themselves. However it's a tiny issue and not really that important.

aljelly avatar Mar 15 '18 16:03 aljelly

Hmm... alright, i'll open the issue again. thank you for specifying

Philip-Scott avatar Mar 16 '18 20:03 Philip-Scott

I've fixed it, I'll submit a pull request soon.

aljelly avatar Mar 16 '18 20:03 aljelly

Sweet! thank you for your work! :)

Philip-Scott avatar Mar 16 '18 20:03 Philip-Scott