Philip Obiora

Results 71 comments of Philip Obiora

> Contributor Yes these values don't have the proper Hexaddress format which are meant to be in 20 byte [] type, based on the firefly-signer library the address must be...

> I will take a look into that @AugustasV you still in or i should take it ?

from #12795 i made adjustments by adding additional checks for the console log, to indicate `"No new console log messages."`, instead of showing the `Error: open : no such file...

> Does this actually fix the issue? My tests show the error is coming from error returned from d.GetInstanceConsoleLog() call. > > Which is before the changes you've made. yes...

Hey @tomponline apologies for the late reply, I have ben busy with school activities . I will surely fix the issue

Hey @tomponline please what make command do i run to test my changes

> The reproducer steps are in #12795 Thank you.

Would like to work on this @nguyer

> @Philip-21 > > > Would like to work on this @nguyer > > I have fixed this in #1388 and [hyperledger/firefly-tokens-erc1155#135](https://github.com/hyperledger/firefly-tokens-erc1155/pull/135) Alright

@awrichar would creating a separate function [here](https://github.com/hyperledger/firefly/blob/main/internal/events/websockets/websocket_connection.go) to stop receiving events/subscription while an individual websocket connection is still open ?