AWS-RedTeam-ADLab icon indicating copy to clipboard operation
AWS-RedTeam-ADLab copied to clipboard

thank you and suggestions

Open abraidotti opened this issue 2 years ago • 0 comments

Hey, Phil. Thanks for putting the files up with detailed instructions. Two years later, the lab works right out of the box! I have a couple suggestions for the readme:

  • add a specific note about editing the aws.tf file for the profile and region if they don't use the defaults.
  • warn user that they may need to turn off microsoft defender to run the adlab.ps1 script
  • add "terraform init" between cd terraform and terraform apply
  • typo in ssm param on line 361 in aws.tf --> "unconstrainer-user" should be "unconstrained-user"

I could otherwise send a PR. Thanks again!

abraidotti avatar Apr 22 '22 17:04 abraidotti