MPAndroidChart icon indicating copy to clipboard operation
MPAndroidChart copied to clipboard

Gradle plugin update to 7.2

Open mdzyuba opened this issue 3 years ago • 6 comments

PR Checklist:

  • [yes] I have tested this extensively and it does not break any existing behavior.
  • [N/A] I have added/updated examples and tests for any new behavior.
  • [N/A] If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

This change makes the library compatible with the latest gradle plugin and Android Studio. The change also updates library dependencies and fixes minor issues related to using deprecated APIs. It also provides a fix to a minor lint error in the libary example. It fixes javadoc classpath error.

mdzyuba avatar May 21 '22 21:05 mdzyuba

Sadly this repo is dead and I helped myself https://github.com/AppDevNext/MPAndroidChart/blob/master/gradle/wrapper/gradle-wrapper.properties

Please see https://github.com/PhilJay/MPAndroidChart/issues/5268

hannesa2 avatar Jun 20 '22 10:06 hannesa2

@hannesa2 I started using your fork before realizing you have no way to interact with the users save for this dead repo.

Firstly, the touches do NOT work on your fork. They do work here.

Secondly, unless you made the issues page open, others will not use it.

Silly I'm complaining about issues in a dead thread, in the wrong place...

dizcza avatar Nov 02 '22 08:11 dizcza

@dizcza Indeed the issues tab was missing. I guess it's the default behavior of a fork. -I changed it-

the touches do NOT work on your fork.

I've no clue, what you are speaking about

Btw, please consider to improve your communication skills. Instead of complaining about something, why something does not work for you, you can make suggestion to improve the situation.

hannesa2 avatar Nov 02 '22 08:11 hannesa2

@dizcza Indeed the issues tab was missing. I guess it's the default behavior of a fork. -I changed it-

the touches do NOT work on your fork.

I've no clue, what you are speaking about

Btw, please consider to improve your communication skills. Instead of complaining about something, why something does not work for you, you can make suggestion to improve the situation.

hannesa2 avatar Nov 02 '22 08:11 hannesa2

@hannesa2 don't take it personal that was me who I made fun of for being silly

Touches callbacks issue: have a look at https://github.com/dizcza/MagneticViewer/blob/master/app/src/main/java/ua/dronesapper/magviewer/SensorLineChart.kt

the touch callbacks are not executed in your fork. So I switched back to the original repo.

dizcza avatar Nov 02 '22 09:11 dizcza

Touches callbacks issue: have a look at https://github.com/dizcza/MagneticViewer/blob/master/app/src/main/java/ua/dronesapper/magviewer/SensorLineChart.kt

@dizcza The link is dead

hannesa2 avatar Jan 05 '23 10:01 hannesa2

Touches callbacks issue: have a look at https://github.com/dizcza/MagneticViewer/blob/master/app/src/main/java/ua/dronesapper/magviewer/SensorLineChart.kt

@dizcza The link is dead

It's moved to https://github.com/dizcza/TcpDataViewer/blob/master/app/src/main/java/ua/dronesapper/tcpdataviewer/SensorLineChart.kt

Let me know if you're working on it. I may switch to your fork and test once it's fixed.


Update Jan 07, 2022

The touches issue is fixed in the fork branch.

dizcza avatar Jan 05 '23 12:01 dizcza