sccp_manager icon indicating copy to clipboard operation
sccp_manager copied to clipboard

Issue when installing sccp_manager on a preexisting host (already running freepbx and chan-sccp)

Open dkgroot opened this issue 4 years ago • 7 comments

@kc2vrj: issues when installing sccp_manager on a host that was already running correctly.

Some suggestions

  1. dont overwrite files if they are already there, suggest changes or write a replacement file and tell people what to do ?
  2. fix bug when creating extconfig.conf it should be using '=>' not '=' to indicate it is configuring a path, currently this is breaking extconfig and realtime
  3. if already existing sccp.conf, suggest a replacement
  4. if non exists, create mostly empty sccp.conf with two include files
    • sccp_additional.conf add only necessary bits to sccp_additional.conf from sccp_manager
    • sccp_custom.conf
  5. ask for the ip-address to write to SEP file for phone to connect to, when server is in multihomed mode
  6. sccp_additional.conf suggestions
    • don't enter anything in sccp.conf if it is a default chan-sccp value already
    • don't set empty parameters in sccp.conf
    • don't set earlyrtp=none by default, this should always be 'progress'.
    • tie down deny/permit if possible. for example by default only permit = 'internal'
    • do set localnet is possible
    • do set externhost / externip if known
  7. don't have Dutch be the default language in the tftp templates, that can mess people up badly. The files in chan-sccp/conf/tftp are example files to be to create templates, not as templates directly.

dkgroot avatar Mar 07 '20 18:03 dkgroot

@PhantomVl Sorry it's a bit of a long list :-( It i can do anything to help you, please give me a shout ! Also i know a lot of these things you inherited from Dave Burges (@Cynjut)'s version. So they are not a critique.

dkgroot avatar Mar 08 '20 06:03 dkgroot

Also should be noted every time you make any edit it remakes the SCPXXXXX.cnf file in TFTP book making it so no changes stay example correcting the server address

kc2vrj avatar Mar 08 '20 22:03 kc2vrj

@PhantomVl Sorry it's a bit of a long list :-( It i can do anything to help you, please give me a shout ! Also i know a lot of these things you inherited from Dave Burges (@Cygnut)'s version. So they are not a critique.

Who is David Brugey?

its-lee avatar Mar 09 '20 09:03 its-lee

Ooh sorry for referring to you Lee, my bad. I meant a different person, and must have misquoted you in. That should have been 'Cynjut'. Sorry for the typo.

dkgroot avatar Mar 09 '20 09:03 dkgroot

Haha, no problem - thanks

its-lee avatar Mar 09 '20 20:03 its-lee

  1. At the time of installation, I transfer the current configuration to the database, rename the old files. Form a working configuration supplemented with default parameters.
  2. The freepbx API is used to work with the configuration and .conf. Asterisk does not distinguish between format differences = and =>
  3. These files are controlled by the system and manual editing is not allowed. In the file and it is written.
  4. I have already written about this somewhere. The current architecture does not allow this
  5. This is a significant flaw, perhaps it 's time to fix it.
  6. ......
  7. :-) @dkgroot These are your templates , I'm ready to replace them with any other ones

PhantomVl avatar Mar 10 '20 07:03 PhantomVl

  1. this can cause trouble, for fields that you are not copying or storing.
  2. Ooh but asterisk does. If i put the "=" in extconfig.conf stuff stops working. Path's need to be specified as "=>" and only variables should use "="
  3. Splitting the files like freepbx might allow more freedom to the user. And instead of altering the files for them, just give them the suggestion or another way to opt-in/opt-out. Just overwriting what they have done manually is very annoying and potentially a loss of information/functionality
  4. Ooh.. I don't understand, how does freepbx create these files then ?
  5. :+1:
  6. :-)
  7. :+1: BTW: I am working on a feature/redesign branch for provision_sccp that will allow you to just generate a provision.ini file and all the templates/phone tftp files will be generated on the fly in cache.. They will be signed and encrypted. No more need to have static ones.

dkgroot avatar Mar 10 '20 09:03 dkgroot