PhanLe1010

Results 277 comments of PhanLe1010

Thanks @bauerjs1 We can keep this one open for the documentation/error message improvements

@MKlimuszka Just want to confirm. This is for Rancher 2.7 charts, right?

Verified the charts and no code modification needed: - [x] Check whether the chart has any references to the below deprecated features of k8s 1.27. You can find information about...

@MKlimuszka Our QA should test with Rancher `rancher/rancher:v2.7-head`, right?

Agree that we can implement it in 1.8.0. Because I am working on v1 performance related topics, I can help to drive this ticket if it is ok Derek

Surely @Kampadais . I am happy to follow your lead!

> > Right now, it will still log even if a particular data engine is disabled even though we already cleanup the corresponding IM and there is no changes in...

> Do you mean we are printing out the log https://github.com/mantissahz/longhorn-manager/blob/a9bff9d1a3ddc496808cc13d7989bc6efed839cf/datastore/longhorn.go#L423-L425 when volumes are attached with dataEngineEnabled false? Hi @mantissahz , this is what I meant. We are printing out...

After discussing with @mantissahz , we think that it is difficult to achieve the behavior at https://github.com/longhorn/longhorn-manager/pull/2539#issuecomment-2043939546. We can keep the current implementation for now

We don't need this one any more, the new AD refactor takes care of the original issue