NotificationPusher icon indicating copy to clipboard operation
NotificationPusher copied to clipboard

[Project] New NotificationPusher version 🎉

Open Ph3nol opened this issue 5 years ago • 8 comments

Hey there,

I plan to develop a new version of NotificationPusher this year, including many new features, and a Dockerized standalone microservice (K8s ready). 🙌🕺 Don't worry, this current version will continue to exist as a legacy version.

This lib has been writen in 2013. 😵 After 1K+ stars on Github and 1M+ installations, it could be great to develop a new opus of it! Of course, this new version will respect all current PHP standards: DDD & TDD powered!

Some questions for you:

  • What do you think about it?
  • Any ideas or suggestions for this new version?

I take this message to thank all the contributors! THANK YOU, you rocks guys! 💪❤️


Feel free to sponsor this project with clicking the Github "Sponsor" button! 🤩 If this allows, I will push the project further (hosted mode, SaaS service and more).

Ph3nol avatar Jul 02 '19 07:07 Ph3nol

@Ph3nol hello, I'm interested to help, maybe. Sounds very good for me to add some DDD flavor into the code, I like DDD a lot. :)

My question is - why not continue with v3 development with refactoring instead of re-writing from scratch? Have you checked this discussion? :) https://github.com/Ph3nol/NotificationPusher/issues/146#issuecomment-320324687

I had a plan in my head also, to do it gradually into v3:

  • change tests coverage to PhpUnit (since it is a standard in PHP)
  • change implementation for IOS from outdated Zend to suggested lib edamov/pushok with k8 support.
  • refactor and drop support for php5.

Does it make sense or not really? :smile:

seyfer avatar Oct 13 '19 19:10 seyfer

It definitely makes sense! 😄

Ph3nol avatar Oct 14 '19 07:10 Ph3nol

@seyfer I had your e-mail. I'll answer you ASAP! 😉

Ph3nol avatar Oct 24 '19 04:10 Ph3nol

  • Symfony 5 is released a couple of weeks ago, so the dependencies on Symfony components should be updated to include Symfony 5 (when I start to migrate my Symfony project I might take a look at this lib and check where compatibility issues occur, if I find some time)
  • I would not drop support for php5 yet... give it another year?

wumke avatar Dec 13 '19 12:12 wumke

@wumke I set it to 5 in this PR https://github.com/Ph3nol/NotificationPusher/pull/195 please review if you have time :slightly_smiling_face:

UPD; actually it is not really possible to allow Symfony 5 until we support PHP5.6 because Symfony 5+ requires php7.2 as the minimum version.

UPD2; actually, from Symfony 4+ they bumped minimum PHP version to 7.1. so for this library Symfony 3.4 is maximum, until php5.6 support will be dropped. Symfony <5 was set here https://github.com/Ph3nol/NotificationPusher/pull/167, which means it includes 4.0 +, but the build will not pass for php5.6 if composer.lock updated.

seyfer avatar May 25 '20 13:05 seyfer

I'm looking for Symfony 5 support, or I will need to stay on Symfony 4 for a while. How did this v3.0 project go? Is there somewhere else to look for this version 3.0?

efreed avatar Apr 25 '21 04:04 efreed

Nobody ever had time. @efreed open-source runs on contributions. You are welcome to help. Otherwise, this library declared as deprecated and you are free to use any other.

seyfer avatar Apr 25 '21 16:04 seyfer

Update: I replaced NotificationPusher in my project with one file per device type that's less than 100 lines.

I'll share them here for anyone interested. https://gist.github.com/efreed/89b64d4c0c2a760466dca170b11e10eb

I don't have experience making files like this into an official composer dependency, if anyone wants to take the code and make it official, go for it, it's yours!

efreed avatar May 05 '21 16:05 efreed