Amber icon indicating copy to clipboard operation
Amber copied to clipboard

[BUG] `--minify` option for `amber build` seems to do nothing

Open lens0021 opened this issue 3 weeks ago • 2 comments

--minify Minify the output file

I never used the option, but it seems to do nothing.

lens0021 avatar Nov 29 '25 00:11 lens0021

It was introduced to strip all the comments

Ph0enixKM avatar Nov 29 '25 10:11 Ph0enixKM

We can remove it entirely (I don't use it) or make it so that it makes the generated output obfuscated.

Although I think I'm against obfuscating Bash. It should be readable for external users what it does.

Ph0enixKM avatar Nov 29 '25 10:11 Ph0enixKM

I thought it is useful for cloud-init's user data format which has a size limit based on cloud platforms.^1 but on the same way, of course, it supports compressed user data,^2 making minifying not necessary. I don't know any other useful case now. But I think there can be a possibility it is useful.

lens0021 avatar Dec 01 '25 05:12 lens0021

Well I think that minify can improve to minify the bash code generated like a lot of enterprise scripts does.

Mte90 avatar Dec 01 '25 10:12 Mte90

I see that we're a bit divided on this. Let's leave it util we see what the community prefers.

Ph0enixKM avatar Dec 02 '25 17:12 Ph0enixKM