Amber icon indicating copy to clipboard operation
Amber copied to clipboard

Implemented AMBER_HEADER and AMBER_FOOTER variables

Open Thesola10 opened this issue 9 months ago • 2 comments

This fixes #344 and #672 by introducing an AMBER_HEADER variable that points to the customizable header file, as well as an AMBER_FOOTER variable to optionally append raw data to the end of the script.

Again, this is a proof-of-concept, and it stands to reason that it could be implemented in a better way, but this can serve as a starting point.

Thesola10 avatar Feb 27 '25 14:02 Thesola10

i've edited this a bit to be more consistent with the rest of our codebase and i think this is ready to be reviewed & merged.

i also hardcoded newline between header and footer to prevent the first line being commented out if the user supplies their own header which doesn't have a newline at the end, like this:

long text with code
echo "hi!"
# my custom header
# amber version: 1.4.0echo hi!

b1ek avatar Mar 10 '25 08:03 b1ek

@Thesola10 can you update this pr with the latest changes?

Mte90 avatar Apr 10 '25 09:04 Mte90

@Thesola10 are there any updates regarding this PR?

Ph0enixKM avatar Jul 09 '25 10:07 Ph0enixKM

@Ph0enixKM as I can remember he said that he doesn't have time anymore to work on the PRs.

The problem is that requires someone skilled with Rust othherwise I will already do it.

Mte90 avatar Jul 15 '25 08:07 Mte90