Amber icon indicating copy to clipboard operation
Amber copied to clipboard

test amber for all bash versions

Open b1ek opened this issue 1 year ago • 2 comments

we should select a minimal supported version, and run all tests on all bash versions, after the minimal supported one. i think its reasonable to support every bash version after 4.0, as it supports hashmaps which we are likely to implement. it is also since 2009, which means it has broad support on most machines

i suggest we download all bash versions after 4.0 from the bash https server, and then execute tests bwrapped with each version, like this:

run_for_ver() {
    curl https://ftp.gnu.org/gnu/bash/$1.tar.gz
    tar xzf $1.tar.gz
    bwrap --bind $1/bin/bash:/usr/bin/bash cargo r -r
    rm -r $1
}

run_for_ver 4.0
run_for_ver 4.1
...
run_for_ver 5.3

b1ek avatar Aug 24 '24 09:08 b1ek

Well it is something that is not very handy and fast... Maybe it is enough the last 4.x and the last 5.x.

Also can be useful a CI that can be turned on not always but just when it is time to do a new release.

Mte90 avatar Aug 26 '24 15:08 Mte90

In my PR, I used Docker Images without knowing this issue. How do you think about the docker approach? Should I rewrite the PR to use binaries?

lens0021 avatar Nov 28 '24 01:11 lens0021

Please reopen this if you have any thoughts.

lens0021 avatar Jun 21 '25 23:06 lens0021