Amber icon indicating copy to clipboard operation
Amber copied to clipboard

Stdlib documentation

Open Mte90 opened this issue 1 year ago • 2 comments

Ref: https://github.com/amber-lang/amber/issues/336

I need a bit of help to improve the documentation also because I didn't understood the purpose of some function.

I think that @CymDeveloppement can help me about it as some of them are by him.

Mte90 avatar Jul 23 '24 12:07 Mte90

Thanks @CymDeveloppement and @KrosFire for the help :-)

We need just to see a couple of points but I think we just need a review from @Ph0enixKM so we can finish that PR :-)

Mte90 avatar Jul 23 '24 14:07 Mte90

Until https://github.com/amber-lang/amber/issues/360 it is addressed this PR can't merged.

Mte90 avatar Jul 25 '24 09:07 Mte90

So it is ready to get approved :-)

Mte90 avatar Aug 30 '24 16:08 Mte90

what about the amber-lang/amber#360? i dont think that has been addressed yet

b1ek avatar Aug 31 '24 07:08 b1ek

Now the PR is free from that issue as I removed the code (the CI works). In this way we can merge it and do the new release as there is no blockers. We implemented too many things in this alpha. When that will be implemented we can improve the stdlib code reusing stuff in the various files.

Mte90 avatar Aug 31 '24 11:08 Mte90

I'm still not a big fan of having the len function in a std/text module and nothing like that in std/array module as it works for both text and arrays. How about creating std/core that has the len function and perhaps some more of the most core and atomic functions? @Mte90 @b1ek @KrosFire

Ph0enixKM avatar Sep 02 '24 10:09 Ph0enixKM

I think that can create confusion. Usually is a native function in a script language, I think that we can keep as it is now and later move as builtin.

Mte90 avatar Sep 02 '24 10:09 Mte90

I'm still not a big fan of having the len function in a std/text module and nothing like that in std/array module as it works for both text and arrays. How about creating std/core that has the len function and perhaps some more of the most core and atomic functions? @Mte90 @b1ek @KrosFire

Let's move it to separate issue. I think that std/core or something like that is a good idea

KrosFire avatar Sep 02 '24 18:09 KrosFire