Amber icon indicating copy to clipboard operation
Amber copied to clipboard

Moving stdlib as repository

Open Mte90 opened this issue 1 year ago • 4 comments

The needs are specific, just to move the discussions in another place, so we can focus in this repo in the compiler itself (and builtins).

The flow:

  • [x] Wait for 0.3.5 release
  • [ ] Merge all the pending PRs for stdlib stuff
  • [x] Create a new repo, https://github.com/amber-lang/amber-stdlib
  • [ ] move them (to define if we can move also the git history or we don't care), remove from this repository (together with tests)
  • [ ] Create in this repository the stdlib as gitmodule so we can block it to a specific commit, symlinked to the actual folders
  • [ ] Update the CI and the readme

Mte90 avatar Jul 19 '24 09:07 Mte90

@Mte90 do you think i can make a PR before moving stdlib ? this is a PR for date function ( #325 )

CymDeveloppement avatar Jul 24 '24 09:07 CymDeveloppement

Yes just do everything now. I am waiting the next release to move to a new repository so we have time.

Just don't forget to add the comments to the various functions.

Mte90 avatar Jul 24 '24 09:07 Mte90

We have 2 folders: immagine

That this repository need to include those 2 but the code organization is not fine for git submodules.

With a build.rs in the root that generate the simlinks we can achieve the symlink easily and in a transparent way for the user if need to compile it https://doc.rust-lang.org/cargo/reference/build-script-examples.html

Mte90 avatar Sep 03 '24 14:09 Mte90

The other issue are tests but looking https://github.com/amber-lang/amber/blob/master/src/tests/stdlib.rs#L5 we don't need symlink

Mte90 avatar Sep 04 '24 09:09 Mte90